Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switched to amd64 version of ipfs #2170

Closed
wants to merge 2 commits into from
Closed

Switched to amd64 version of ipfs #2170

wants to merge 2 commits into from

Conversation

Luzifer
Copy link
Member

@Luzifer Luzifer commented Jan 7, 2016

@Luzifer
Update alpine to latest stable
a3417bd 
License: MIT
Signed-off-by: Knut Ahlers <[email protected]>
@Luzifer
Switched to amd64 version of ipfs
c884d24 
- Also cleaned the Dockerfile a bit and made it more easy to read.
- Also moved the VOLUME statement (refs #1804)
- Includes #2169

License: MIT
Signed-off-by: Knut Ahlers <[email protected]>
@whyrusleeping
Copy link
Member

This looks good to me, but i'm not any good at docker stuff. @lgierth CR here?

@ghost
Copy link

ghost commented Jan 7, 2016

LGTM!

@rht
Copy link
Contributor

rht commented Jan 22, 2016

Reminder to rebase.

@Luzifer
Copy link
Member Author

Luzifer commented Jan 22, 2016

As we are now (#2212) building ipfs inside the container it should be amd64… Needs verification, afterwards this can be closed… Well… This can be closed anyway…

@Luzifer Luzifer closed this Jan 22, 2016
@Luzifer Luzifer deleted the docker_amd64 branch September 7, 2018 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker out of memory crash (32 bit binary used)
3 participants
@Luzifer @whyrusleeping @rht